Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky headers count as layout thrashing #14709

Open
turt2live opened this issue Jul 22, 2020 · 3 comments
Open

Sticky headers count as layout thrashing #14709

turt2live opened this issue Jul 22, 2020 · 3 comments
Labels
A-Performance A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Product More input needed from the Product team

Comments

@turt2live
Copy link
Member

Because we're altering classes on a bunch of headers the browser ends up in a read-write-read-write loop, which forces synchronous layouts to happen.

@germain-gg
Copy link
Contributor

@turt2live
Copy link
Member Author

I WOULD LOVE IT IF WE COULD. Because of the flexbox layout (which is questionable, but necessary at the moment) the bottom header ends up not sticking correctly and will stick below the room list. Plus, there's the added complexity of transparency effects which mean that we need reserved spaces for the background to bleed through.

I would definitely timebox this if anyone works on it.

@germain-gg germain-gg added the P1 label May 17, 2021
@germain-gg germain-gg self-assigned this May 18, 2021
@germain-gg germain-gg added the X-Needs-Product More input needed from the Product team label Jul 29, 2021
@novocaine
Copy link
Contributor

@gsouquet can you post screenshots or videos explaining what you've changed so product and design can review it?

@MadLittleMods MadLittleMods added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Sep 6, 2022
@kittykat kittykat removed the P1 label Oct 18, 2022
@germain-gg germain-gg removed their assignment Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Performance A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Product More input needed from the Product team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants