Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed message notification not visible when the left panel is collapsed #18890

Closed
1 of 8 tasks
kittykat opened this issue Sep 3, 2021 · 1 comment
Closed
1 of 8 tasks
Labels
A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect

Comments

@kittykat
Copy link
Contributor

kittykat commented Sep 3, 2021

Steps to reproduce

  1. Collapse left panel (because your device has a small screen)
  2. Send message while the network is dropping out
  3. Navigate to a different room
    -> Message fails to send
    -> User is not notified of failure while under the assumption that it has sent
    -> Message is not sent automatically when network becomes available again

What happened?

Screenshot from 2021-09-03 12-11-27

What did you expect?

Something like this:
proposed

We already have prior art for overlaying notifications on avatars:
Screenshot from 2021-09-03 14-04-55

URL for webapp

develop.element.io

Development checklist

  • Tagged as T-Defect, and with correct A-, S- and O-* labels
  • Can be reproduced from steps (see above)
  • Developer has acquired all needed info from issue author and issue is not labelled with X-Needs-Info
  • Design team has signed off on the feature: final design has been approved by the Element design team and attached to this issue:
  • Acceptance criteria (in scope) have been clearly defined:
    • Failure warning is visible when the left panel is collapsed
  • Out of scope:
    • Moving all notifications to show in a collapsed panel (file new issues for these if needed)
@kittykat kittykat added T-Defect S-Critical Prevents work, causes data loss and/or has no workaround A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely labels Sep 3, 2021
@novocaine novocaine added this to the App Team 1.8.4 milestone Sep 8, 2021
@novocaine novocaine modified the milestones: App Team 1.8.6, App Team 1.8.7 Sep 22, 2021
@janogarcia
Copy link

janogarcia commented Oct 6, 2021

This is no longer happening. Now the error status badge is displayed on both the user avatar and the space icon for failed messages. 👍

Failed Message - Sidebar

Failed Message - Timeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants