Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room list filter and member list filter have different text colors #8194

Closed
jryans opened this issue Jan 21, 2019 · 5 comments
Closed

Room list filter and member list filter have different text colors #8194

jryans opened this issue Jan 21, 2019 · 5 comments
Labels
P2 S-Tolerable Low/no impact on users T-Defect

Comments

@jryans
Copy link
Collaborator

jryans commented Jan 21, 2019

2019-01-21 at 13 54

2019-01-21 at 13 54

Member list filter text color is harder to read, so maybe it should switch to be the same as room list filter text color?
@jryans jryans added T-Defect ui/ux S-Tolerable Low/no impact on users labels Jan 21, 2019
@jryans jryans mentioned this issue Jan 21, 2019
Merged
@nadonomy
Copy link
Contributor

Not sure what's happening here exactly (FF specific bug?), the text should match the icon and does so in Safari:

screenshot 2019-01-21 at 20 04 22

And yep; the filter members text should match filter room names (as per the first bullet in #8182).

@jryans
Copy link
Collaborator Author

jryans commented Jan 21, 2019

the filter members text should match filter room names (as per the first bullet in #8182)

Ah, fair enough... I only read #8182 as "fix the regression", so that's all I did over there. Anyway, now we have this issue for remaining fixes.

@jryans jryans mentioned this issue Jan 21, 2019
Closed
@jryans
Copy link
Collaborator Author

jryans commented Jan 21, 2019

Not sure what's happening here exactly (FF specific bug?), the text should match the icon and does so in Safari:

screenshot 2019-01-21 at 20 04 22

Moved this Firefox specific bit to #8195.

@lampholder lampholder added the P2 label Apr 30, 2019
@aaronraimist
Copy link
Collaborator

Related: #12630

@t3chguy
Copy link
Member

t3chguy commented Apr 11, 2020

This seems to be resolved
image
image
image
image

@t3chguy t3chguy closed this as completed Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jryans @lampholder @t3chguy @nadonomy @aaronraimist