Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: “Expand” the UI to take full advantage of the screen #1866

Open
MIfoodie opened this issue Mar 8, 2023 · 10 comments
Open

feat: “Expand” the UI to take full advantage of the screen #1866

MIfoodie opened this issue Mar 8, 2023 · 10 comments
Labels
c: feature Request for new feature

Comments

@MIfoodie
Copy link

MIfoodie commented Mar 8, 2023

852A53CC-CB48-4239-8095-E82DF91319D6

This is a little mock-up I did of where you could resize and reposition UI elements to make better use of the screen

I hope it’s not too messy :) 🖍️

@MIfoodie MIfoodie added the s: pending triage Pending Triage label Mar 8, 2023
@stackblitz
Copy link

stackblitz bot commented Mar 8, 2023

Solve in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

@MIfoodie MIfoodie changed the title “Expand” the UI to take full advice of the strewn feat: “Expand” the UI to take full advantage of the screen Mar 8, 2023
@ayoayco
Copy link
Member

ayoayco commented Mar 9, 2023

One accessibility consideration here. Expanding the status/post card will mean more characters to read per line. There's an optimum number of characters per line that we keep to make it easy on the eyes to read.

@patak-dev patak-dev added c: feature Request for new feature and removed s: pending triage Pending Triage labels Mar 11, 2023
@patak-dev
Copy link
Member

There have been several others asking for this. We can leave it open for people to discuss but I think it is a really hard feature to implement and maintain. The issue is that the current layout for posts expects you to have a width of 600px (or a bit less). Expansions, attachments, polls, and other features are implemented with this in mind. I think a possible way to keep this simple would be to allow for wider posts (let's say 1200px), and then when there is a post card use two columns with the card on the right and the post text on the left. I don't know how good this would look but at least it is something that feels doable.

@MIfoodie
Copy link
Author

I found this extension thing that uses the whole screen for mastodon and it looks pretty nice. https://codeberg.org/Freeplay/Mastodon-Modern

@ayoayco
Copy link
Member

ayoayco commented Mar 14, 2023

I think this should also be left for user-land solutions like a browser extension 😄

@bhcompy
Copy link

bhcompy commented Mar 6, 2024

Guess there's no movement on this? Kind of looks comical on a 1440p monitor. It's so sad and lonely with all that padding

@Christopher-Hayes
Copy link
Contributor

I don't think it's unreasonable to want to use that space for sidebars and other content, but expanding the posts to be basically fullscreen would definitely harm readability, not to mention WCAG. This might not be obvious on a smaller laptop screen, but on 1440p this would be a serious problem.

For example, this is how it would look on 1440p:
image

However, if Elk goes through a redesign, a slightly wider post layout could still totally work, just probably not fullscreen. This would likely need larger font sizes and padding to make it all work. Elk is already using rem on fonts, so font-size on larger screens could be tweaked pretty easily, for example:

image

@bhcompy
Copy link

bhcompy commented Jul 23, 2024

I understand what you're saying, but I happen to like it. I mean I guess I can use tampermonkey to fix it, as I've found or created solutions for other sites that have the same limitations. Choice is nice. Luckily, browsers aren't completely constrained

@nileshtrivedi
Copy link

nileshtrivedi commented Aug 29, 2024

Whalebird has a Slack/Discord like interface which is really great, but it works for them because Whalebird is a desktop-only client.

image

I am interested in showing the Followed Hashtags in the Elk sidebar if on large screens (again, like Slack/Discord):

image

This might work as a tampermonkey script:

const nav = document.querySelector('nav');
const topics = ['elk', 'mozilla'];
const hashtagsLink = nav.querySelector('a[href="/hashtags"]');

if (hashtagsLink) {
  topics.forEach(text => {
    const a = document.createElement('a');
    a.href = "#";
    a.addEventListener('click', function(){
      window.useNuxtApp().$router.push(`/fosstodon.org/tags/${text.toLowerCase()}`);
    });
    a.className = "";

    a.innerHTML = `
<div class="v-popper v-popper--theme-tooltip">
  <div class="item w-fit rounded-3 px2 mx3 sm:mxa transition-100 elk-group-hover-bg-active group-focus-visible:ring-2 group-focus-visible:ring-current" flex="" items-center="" gap4="" xl="ml0 mr5 px5 w-auto">
              <div class="i-ri:hashtag" text-xl=""></div>
              <span block="" sm:hidden="" xl:block="" select-none="">${text}</span>
  </div>
</div>
`;
    hashtagsLink.insertAdjacentElement('afterend', a);
  });
};

@nileshtrivedi
Copy link

nileshtrivedi commented Sep 1, 2024

I implemented the above feature (followed hashtags in the sidebar for Slack/Discord-like topic-wise browsing/discovery) and in Whalebird desktop client and love it! Would love to see this implemented in Elk too.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature
Projects
None yet
Development

No branches or pull requests

6 participants