From ae1b6ade4551e4d39713c3d535d3775781cb4d0b Mon Sep 17 00:00:00 2001 From: Liam O'Boyle Date: Sun, 25 Sep 2022 19:38:17 +1000 Subject: [PATCH] Limit columns selected in `expression_is_true` if failures not stored. Fixes #683 --- macros/generic_tests/expression_is_true.sql | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/macros/generic_tests/expression_is_true.sql b/macros/generic_tests/expression_is_true.sql index 611685b41..b8aa7ad43 100644 --- a/macros/generic_tests/expression_is_true.sql +++ b/macros/generic_tests/expression_is_true.sql @@ -6,12 +6,14 @@ {% macro default__test_expression_is_true(model, expression, column_name, condition) %} +{% set column_list = '*' if should_store_failures() else "1" %} + with meet_condition as ( select * from {{ model }} where {{ condition }} ) select - * + {{ column_list }} from meet_condition {% if column_name is none %} where not({{ expression }})