Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of support for Less 3 means npm audit is unhappy with this package #150

Closed
boutell opened this issue May 15, 2018 · 5 comments
Closed

Comments

@boutell
Copy link

boutell commented May 15, 2018

npm audit is flagging many security issues with less 2.x, which is required for this package. I'm looking at forking temporarily to use less 3, in the hopes it'll play nice as it doesn't seem to have a lot of bc breaks API-wise.

@boutell
Copy link
Author

boutell commented May 15, 2018

(Of course we'd rather be on the mainline version of this package.)

@boutell
Copy link
Author

boutell commented May 15, 2018

Tests pass with LESS 3 and nontrivial stuff seems to work fine with apostrophe under it. There's really nothing to PR, as all I did was change the dependency. What are your thoughts on going to 3.x? With a major version bump of your own presumably...

@boutell
Copy link
Author

boutell commented May 15, 2018 via email

@Zoramite
Copy link
Member

Just double checking the tests then I'll be releasing it.

@boutell
Copy link
Author

boutell commented May 16, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants