needs not resolving after module change

[emmagamma]

v2.1.0...v0.4.23

Prior to this^ change, the module variable would always be declared with a Constructor and now it begins as undefined and is assigned a value inside the setup function.

It seems this has broken the needs in my tests, which aren't being properly resolved, I think as a result of the module not receiving the description either at all or not at the right time?

for now (if you're running into this issue) you should be able to just shrinkwrap or pin the version of q-unit to 4.22, and things should go green again.

[steveax]

Perhaps a bit of a clue, 0.4.22 output:
ok 50 PhantomJS 2.1 - Exam Partition #1 - Unit | Model | job: it exists

0.4.23 output:
ok 50 PhantomJS 2.1 - Exam Partition #1 - jobs.job: it exists

Test module:

moduleForModel('jobs.job', 'Unit | Model | job', {
  needs: [
    'model:rbac/user',
    'model:jobs/job/node'
  ]
});

Here's the stack trace from the test:

not ok 53 PhantomJS 2.1 - Exam Partition #1 - jobs.job: isRunning
    ---
        actual: >
            null
        stack: >
            http://localhost:7357/assets/vendor.js:177808
        message: >
            Died on test #1 testWrapper@http://localhost:7357/assets/test-support.js:6763:16
            test@http://localhost:7357/assets/test-support.js:6777:44
            http://localhost:7357/assets/tests.js:74613:24
            exports@http://localhost:7357/assets/vendor.js:123:37
            requireModule@http://localhost:7357/assets/vendor.js:38:25
            require@http://localhost:7357/assets/test-loader.js:67:16
            http://localhost:7357/assets/test-support.js:6511:26
            forEach@[native code]
            _loadSplitModules@http://localhost:7357/assets/test-support.js:6510:25
            load@http://localhost:7357/assets/test-loader.js:89:35
            http://localhost:7357/assets/test-support.js:6397:20: No model was found for 'rbac/user'
        Log: |

Ember: 2.4.6
Ember Data: 2.12.1
jQuery: 2.2.4

[trentmwillis]

Apologies to everyone affected, I'm looking into and will hopefully have a fix shortly

[emmagamma]

awesome ~ thanks, @trentmwillis!

[steveax]

No worries, these things happen - feel free to ping if I can provide any more info.

[trentmwillis]

We've reverted the changes introduced in 0.4.23 and released 0.4.24, which should fix any problems introduced by that release.