Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for request params behavior changes (#3364) #3440

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Add test for request params behavior changes (#3364) #3440

merged 4 commits into from
Dec 3, 2024

Conversation

GreyElaina
Copy link
Contributor

Summary

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@GreyElaina
Copy link
Contributor Author

cc @tomchristie

tomchristie
tomchristie reviewed Dec 3, 2024
View reviewed changes
@tomchristie tomchristie merged commit 8ecb86f into encode:master Dec 3, 2024
5 checks passed
@tomchristie
Copy link
Member

Thanks @GreyElaina @zanieb.

@daniel-k daniel-k mentioned this pull request Jan 16, 2025
Merged
daniel-k added a commit to enlyze/enlyze-python that referenced this pull request Jan 16, 2025
@daniel-k
Fix incompatibility with httpx>=0.28 (#52)
b188f07 
In `httpx==0.28.0`, the handling of GET query parameters has changed in
a backwards-incompatible way. The new behaviour is to replace query
parameters in the URL when parameters are passed via the `params` kwarg.
Our pagination code expects that parameters in the URL get merged with
the additional parameters of the `params` kwarg. This PR explicitly
implements the old behaviour of merging params to fix compatibility with
recent releases of `httpx`.

refs: 
- encode/httpx#3364
- encode/httpx#3440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie left review comments

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GreyElaina @tomchristie @zanieb