Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] production configuration of gunicorn #642

Closed
sandys opened this issue Sep 19, 2019 · 1 comment
Closed

[question] production configuration of gunicorn #642

sandys opened this issue Sep 19, 2019 · 1 comment

Comments

@sandys
Copy link

sandys commented Sep 19, 2019

hi guys,
so i am looking to go to production using starlette or a derivative of starlette (fastapi,etc).

I'm looking at this as my starting script for a production configuration of gunicorn - https://github.com/tiangolo/uvicorn-gunicorn-docker/blob/master/python3.7/gunicorn_conf.py

is this good enough ? I'm not sure if i should be using threads (because of the async nature of starlette) or other gunicorn configs

On reading documentation of gunicorn with uvicorn, there are lines like this

"Gunicorn provides a different set of configuration options to Uvicorn, so some options such as --limit-concurrency are not yet supported when running with Gunicorn"

This is for a medium-high traffic site. any help would be much appreciated.

@tomchristie
Copy link
Member

Seems perfectly reasonable yup.

I reckon we'll probably start to just recommend running uvicorn on it's own at some point, but provide the Gunciron worker classes as a third party option. encode/uvicorn#517 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants