Replies: 3 comments
This comment was marked as off-topic.
This comment was marked as off-topic.
-
cc @encode/maintainers |
Beta Was this translation helpful? Give feedback.
0 replies
-
I have nothing against that |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Checklist
Is your feature related to a problem? Please describe.
uvicorn
is the fastest ASGI server available for HTTP/1.1, but I'm afraid that time can be dangerous if we don't take preventive measures to maintain its current rank.The proposal here is nothing exaggerated: just create performance tests. I had this thought when I was looking on the h11 repository and PRs, as they run their benchmark to make sure that PRs don't drop its performance.
Describe the solution you would like.
I think we could make use of this example and "amplify" the idea and create an action to be triggered every time we push a commit on a PR, and run this benchmark, receiving a message on that PR saying how long that benchmark took, and compare the results with the latest
master
.I'm assuming that the environment is a controlled one, so the same variables will be applied for each execution, and the results are meaningful ones.
Describe alternatives you considered
Beta Was this translation helpful? Give feedback.
All reactions