Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Round methods #93

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Merge Round methods #93

merged 2 commits into from
Feb 18, 2025

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Feb 11, 2025

@fjarri fjarri self-assigned this Feb 11, 2025
@fjarri fjarri force-pushed the merge-methods branch 2 times, most recently from 0e98e9f to edd0d70 Compare February 11, 2025 00:35
@coveralls
Copy link

coveralls commented Feb 13, 2025

Pull Request Test Coverage Report for Build 13401846642

Details

  • 167 of 222 (75.23%) changed or added relevant lines in 8 files are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 73.193%

Changes Missing Coverage Covered Lines Changed/Added Lines %
manul/src/session/session.rs 24 25 96.0%
manul/src/combinators/chain.rs 10 12 83.33%
manul/src/session/evidence.rs 6 9 66.67%
manul/src/protocol/round_id.rs 92 141 65.25%
Files with Coverage Reduction New Missed Lines %
manul/src/session/tokio.rs 13 82.38%
Totals Coverage Status
Change from base Build 13249464815: -0.4%
Covered Lines: 2288
Relevant Lines: 3126

💛 - Coveralls

@fjarri fjarri force-pushed the merge-methods branch 4 times, most recently from 49296fa to 12349c2 Compare February 16, 2025 23:19
@fjarri fjarri marked this pull request as ready for review February 16, 2025 23:20
@fjarri fjarri requested a review from dvdplm February 16, 2025 23:20
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a nice cleanup. Left a few nitpicks.

@fjarri fjarri merged commit 93f62ec into entropyxyz:master Feb 18, 2025
8 checks passed
@fjarri fjarri deleted the merge-methods branch February 18, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More consistent handling of out-of-order messages Merge some of the Round methods
3 participants