feat: set aud claim to Issuer
#418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulswartz
force-pushed
the
aud-as-issuer-with-override
branch
from
c90015b to
afefaf7
Compare
At some point, this became part of the FAPI2 spec: https://openid.bitbucket.io/fapi/fapi-security-profile-2_0.html#section-5.3.1 > Authorization servers [...] shall only accept its issuer identifier value (as defined in [RFC8414]) as a string in the aud claim received in client authentication assertions; This also generally works with regular OIDC endpoint as well. To allow for the old behavior, we provide a `token_request_claims` option which can explicitly set any claims for the token request.
paulswartz
force-pushed
the
aud-as-issuer-with-override
branch
from
afefaf7 to
287fc2b
Compare
maennchen
approved these changes
Feb 10, 2025
|
Thanks ❤️ |
Pull Request Test Coverage Report for Build 249Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 251Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point, this became part of the FAPI2 spec:
https://openid.bitbucket.io/fapi/fapi-security-profile-2_0.html#section-5.3.1
This also generally works with regular OIDC endpoint as well. To allow for the old behavior, we provide a
token_request_claimsoption which can explicitly set any claims for the token request.