Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate arguments to validate_jwt fn #422

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Validate arguments to validate_jwt fn #422

merged 1 commit into from
Feb 21, 2025

Conversation

maennchen
Copy link
Member

Fixes #421

@maennchen maennchen added the bug label Feb 21, 2025
@maennchen maennchen self-assigned this Feb 21, 2025
@maennchen
Copy link
Member Author

@Nezteb Does that cover what you had in mind?

@Nezteb
Copy link
Contributor

Nezteb commented Feb 21, 2025

Can we also update the code examples for validate_jwt?

Then anyone referencing the code will understand the usage at a glance? 🙏

@maennchen maennchen force-pushed the jm/validate_jwt_badarg branch from 3900b69 to a41dd1a Compare February 21, 2025 19:04
@maennchen
Copy link
Member Author

@Nezteb I extended the example. Thanks for your review :)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 255

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 92.143%
Totals Coverage Status
Change from base Build 231: 0.3%
Covered Lines: 1079
Relevant Lines: 1171
💛 - Coveralls

@maennchen maennchen merged commit 09d2b5a into main Feb 21, 2025
26 checks passed
@maennchen maennchen deleted the jm/validate_jwt_badarg branch February 21, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nezteb Nezteb Nezteb left review comments

Assignees

@maennchen maennchen

Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@maennchen @Nezteb @coveralls