Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AA-540: Extract the 'iterateValidationPhase' function #547

Merged
merged 28 commits into from
Feb 26, 2025
Merged

AA-540: Extract the 'iterateValidationPhase' function #547

merged 28 commits into from
Feb 26, 2025

Conversation

forshtat
Copy link
Collaborator

No description provided.

forshtat and others added 22 commits February 23, 2025 14:36
@forshtat
Make 'handleOps' function 'external' instead of 'public'
67fdcea
@forshtat
gaschecker
5ba39f1
@forshtat
Explicit 'i = 0' adds about 36 gas cost unnecessarily
8c5d1c8
@forshtat
Add UserOp index to the SignatureValidationFailed error
5901058
@forshtat
fix
4dfdb30
@forshtat
Change "AA93 invalid paymaster" to "AA98 invalid paymaster"
68719eb
@forshtat
Reorder '_callValidateUserOp' parameters for consistency
8488a1a
@forshtat
Make the "getFreePtr"/"restoreFreePtr" block explicit
b51424c
@forshtat
Make "block.timestamp == data.validAfter" also return true
05bf6d5
@forshtat
Replace 'if () revert' with 'require' for "AA25 invalid account nonce…
747de36 
…" error
@forshtat
Simplify the 'PENALTY_GAS_THRESHOLD' check logic
0beb02f
@forshtat
Fix comments
85230cc
@shahafn
Fixing tests
e3d38e0
@forshtat
Fix gas
50ed733
@forshtat
Undo removal of "for (uint256 i = 0;"
f607cf6
@drortirosh
document getFreePtr/restoreFreePtr
5a160ab
@drortirosh
fix SignatureAggregationFailed usage.
ac07785
@drortirosh
IPaymaster comment
59f3882
@drortirosh
gascalcs
ec606e7
@forshtat
Update entrypoint.test.ts
8cf5b52
@drortirosh
fixed test
7ee97e3
@forshtat
AA-540: Extract the 'iterateValidationPhase' function
6aadb22
Base automatically changed from minor_updates_audit to develop February 25, 2025 14:31
shahafn
shahafn approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@shahafn shahafn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think that at least for consistency, the same should be done with the execution loop. In both cases (validation and execution) we don't spare many duplicate lines anyway.

@forshtat forshtat merged commit 4b386fb into develop Feb 26, 2025
8 checks passed
@forshtat forshtat deleted the aa-540 branch February 26, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahafn shahafn shahafn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@forshtat @shahafn @drortirosh