Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussions-to thread for EIP-2098 (Compact Signature Representation) #2440

Closed
ricmoo opened this issue Dec 16, 2019 · 11 comments
Closed

Discussions-to thread for EIP-2098 (Compact Signature Representation) #2440

ricmoo opened this issue Dec 16, 2019 · 11 comments

Comments

@ricmoo
Copy link
Contributor

ricmoo commented Dec 16, 2019

This is a discussions-to thread (as per EIP-1) for: EIP-2098 Compact Signature Representation.

This topic section may be updated occasionally to reflect additional information which becomes relevant to interested parties.

@axic
Copy link
Member

axic commented Dec 16, 2019

Ah, since this references the constraints of Homestead, should have added requires: 2 to the header.

@frangio
Copy link
Contributor

frangio commented Mar 16, 2021

Is there any interest in moving this EIP to Final? We would include an implementation in OpenZeppelin but are concerned about breaking changes. Not sure if it would even be possible to introduce any breaking changes in this format though...

@ricmoo
Copy link
Contributor Author

ricmoo commented Mar 16, 2021

Yes, I was chatting last night with someone about moving it forward. I will add the requires, do one more round of reading it over and change its status to review. :)

@MicahZoltu
Copy link
Contributor

If you do pick this back up, I recommend renaming v to yParity which is the nomenclature we have been using in new signatures like EIP-1559, EIP-2930, EIP-2711, etc.

@ricmoo
Copy link
Contributor Author

ricmoo commented Mar 17, 2021

Cool, I’ll make that change too then.

What do you think would make the most sense for a name for the composite? Right now I use vs, but yParityS?

@MicahZoltu
Copy link
Contributor

I'm a huge fan of verbose names so in any code I write it would likely be called yParityAndS or something. I know not everyone agrees with my desires for verbosity though.

@ricmoo
Copy link
Contributor Author

ricmoo commented Jun 22, 2021

I've updated the status to Review. I believe it requires an editor to approve the change. Do I need to ping someone directly, or will it be picked up on the next sweep?

@MicahZoltu
Copy link
Contributor

An editor should see the change automatically, no need to do anything other than submit the PR that changes the status.

@github-actions
Copy link

There has been no activity on this issue for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@sambacha
Copy link
Contributor

Isn't this EIP already finalized? https://eips.ethereum.org/EIPS/eip-2098

@ricmoo
Copy link
Contributor Author

ricmoo commented Mar 20, 2022

Yes it is finalized. I guess this issue should be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@axic @frangio @MicahZoltu @ricmoo @sambacha and others