You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Command consume direct should support EOF fixtures, since tools like evmone-eofparse allow consumption of EOF containers.
The command technically already supports EOF fixtures with the merging of #935, but currently there is no fixture-consumer class defined to process EOF fixtures.
The only thing required is to create a FixtureConsumerTool subclass that contains the logic to process the fixtures using the evmone-eofparse external tool, like the one defined for Geth's evm tool here:
The main difference between Geth's class and evmone's class is that evmone-eofparse is a different binary than the one used in the transition tool (evmnone-t8n).
This comment describes partially what this entails:
danceratopz
changed the title
consume: Add support to consume direct for EOF test fixtures
feat(consume): add support to consume direct for eof_test fixtures
Feb 21, 2025
felix314159
added a commit
to felix314159/execution-spec-tests
that referenced
this issue
Feb 24, 2025
Command
consume direct
should support EOF fixtures, since tools likeevmone-eofparse
allow consumption of EOF containers.The command technically already supports EOF fixtures with the merging of #935, but currently there is no fixture-consumer class defined to process EOF fixtures.
The only thing required is to create a
FixtureConsumerTool
subclass that contains the logic to process the fixtures using theevmone-eofparse
external tool, like the one defined for Geth'sevm
tool here:execution-spec-tests/src/ethereum_clis/clis/geth.py
Lines 246 to 251 in 2a1e031
During
consume direct
execution, this new class would receive the EOF fixture path in this endpoint:execution-spec-tests/src/ethereum_clis/clis/geth.py
Lines 368 to 374 in 2a1e031
The main difference between Geth's class and evmone's class is that
evmone-eofparse
is a different binary than the one used in the transition tool (evmnone-t8n
).This comment describes partially what this entails:
https://github.com/ethereum/execution-spec-tests/pull/935/files#r1907541619
Tasks
The text was updated successfully, but these errors were encountered: