Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with pydantic FixtureHeader validation #1259

Open
winsvega opened this issue Feb 25, 2025 · 0 comments
Open

Issues with pydantic FixtureHeader validation #1259

winsvega opened this issue Feb 25, 2025 · 0 comments

Comments

@winsvega
Copy link
Contributor

winsvega commented Feb 25, 2025

Using existing pydantic models issues:

  • can't have default fields.
    because we must verify that all required fields are provided in test json.

  • conflict between hash and block_hash dynamic field
    we compute hash value on request, but we must use the one provided by test in hash field. this must be one fields but perhaps can use a trick to set it to None and compute it on post validation step if it is None

  • multiple aliases does not guarantee that generated test structure always follow same name format
    seems like multiple aliases will allow the structure to have inconsistent naming format, when we expect tests to have fixed field names in structures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant