Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): EOF - EIP-7620: verify RETURNCONTRACT does not overwrite containing contract #1109

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

shemnon
Copy link
Collaborator

@shemnon shemnon commented Jan 23, 2025

🗒️ Description

Test the case where adding auxdata to a subcontainer could result in the parent containers data section if the subcontainer were not copied.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Test the case where adding auxdata to a subcontainer could result in the
parent containers data section if the subcontainer were not copied.

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm confused a bit by the premise though: did an implementation overwrite the data of a contract that was already in the state?

Thanks!

@marioevz marioevz changed the title feat(tests) verify RETURNCONTRACT does not overwrite containing contract feat(tests): EOF - EIP-7620: verify RETURNCONTRACT does not overwrite containing contract Jan 27, 2025
@shemnon
Copy link
Collaborator Author

shemnon commented Jan 28, 2025

That's exactly what happened, and I only claim trophies for my fuzzer when I have an EEST test demonstrating the breakage: https://github.com/shemnon/execution-spec-tests/blob/shemnon/eof-fuzz/src/ethereum_fuzzer_differential/__init__.py#L20-L22

@shemnon shemnon merged commit 8288c0b into ethereum:main Jan 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants