Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): fix TSTORE EOF variant test #831

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix(tests): fix TSTORE EOF variant test #831

merged 1 commit into from
Sep 24, 2024

Conversation

shemnon
Copy link
Collaborator

@shemnon shemnon commented Sep 23, 2024 •
edited by danceratopz
Loading

🗒️ Description

The runtime code of the TSTORE test is not valid EOF, it requires a
terminating instruction.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@shemnon
fix EOF TSTORE test
661774d 
The runtime code of the TSTORE test is not valid EOF, it requires a
terminating instruction.

Signed-off-by: Danno Ferrin <[email protected]>
@danceratopz danceratopz added type:bug Something isn't working scope:tests Scope: Changes EL client test cases in `./tests` labels Sep 24, 2024
@danceratopz danceratopz changed the title fix(tests) Fix TSTORE EOF Variant Test fix(tests): fix TSTORE EOF variant test Sep 24, 2024
danceratopz
danceratopz approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM )

@danceratopz danceratopz merged commit 0767d80 into ethereum:main Sep 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danceratopz danceratopz danceratopz approved these changes

Assignees
No one assigned
Labels
scope:tests Scope: Changes EL client test cases in `./tests` type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shemnon @danceratopz