Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor(gentest): Migrate transaction test to state_test #903

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

raxhvl
Copy link
Contributor

@raxhvl raxhvl commented Oct 21, 2024

🗒️ Description

This PR migrates the transaction gentest from blockchain_test to state_test. It also documents the rationale under "Writing Tests" .

🔗 Related Issues

Closes #864

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion - very astute! You're right, gentest as-is should absolutely be (natively) a state_test and not a blockchain_test. Thanks for this and the doc improvements!

Small comment, we favor line wrapping in the IDE (i.e., use a single line for a paragraph) instead of manual line breaks as it makes them easier to diff. Could you please modify that in types_of_tests.md?

@raxhvl raxhvl closed this Nov 7, 2024
@raxhvl raxhvl reopened this Nov 7, 2024
@raxhvl
Copy link
Contributor Author

raxhvl commented Nov 7, 2024

I have rebaed on main and addressed all comments.

@raxhvl raxhvl requested a review from danceratopz November 7, 2024 05:54
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this @raxhvl. Appreciate the improvements to the documentation.

Very minor: I'll just remove a couple of linebreaks in the markdown before merge.

@danceratopz danceratopz merged commit 61aad9e into ethereum:main Nov 7, 2024
3 checks passed
@raxhvl raxhvl deleted the feat/gentest-864 branch December 11, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞(gentest): generate test cases as a state_test for single transactions
2 participants