Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat(fw,fill,cli): Default evm logs #999

Merged
merged 3 commits into from
Dec 16, 2024
Merged

✨ feat(fw,fill,cli): Default evm logs #999

merged 3 commits into from
Dec 16, 2024

Conversation

raxhvl
Copy link
Contributor

@raxhvl raxhvl commented Dec 5, 2024 •
edited
Loading

🗒️ Description

The PR adds a default location for evm logs (--evm-dump-dir) when filling tests. Please review if the proposed directory is appropriate.

🔗 Related Issues

closes #978

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

marioevz
marioevz approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks so much!

@marioevz
Copy link
Member

Added a fix for the failing tox tests: If the test being filled does not live under ./tests, the output directory to dump the evm logs could not be calculated correctly.

Will merge once the CI passes.

@marioevz marioevz merged commit bacb56e into ethereum:main Dec 16, 2024
3 checks passed
@raxhvl raxhvl deleted the feat/logs branch December 19, 2024 07:24
codeofcarson pushed a commit to codeofcarson/execution-spec-tests that referenced this pull request Jan 24, 2025
@raxhvl @marioevz @codeofcarson
✨ feat(fw,fill,cli): Default evm logs (ethereum#999)
d7ee464 
* ✨ feat(fw,fill,cli): Default evm logs

* fix(fixtures): EVM dump logs with no common path

* feat(plugins/filler): Add flag to skip evm dump

---------

Co-authored-by: rahul <[email protected]>
Co-authored-by: Mario Vega <[email protected]>
This was referenced Jan 29, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--evm-dump-dir to have default value
2 participants
@raxhvl @marioevz