Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics options are ignored in config.toml #28303

Closed
VladStarr opened this issue Oct 10, 2023 · 3 comments
Closed

Metrics options are ignored in config.toml #28303

VladStarr opened this issue Oct 10, 2023 · 3 comments
Labels

Comments

@VladStarr
Copy link

System information

Geth version: 1.13.2-stable
CL client & version: prysm v4.0.8
OS & Version: Linux
Commit hash :

Expected behaviour

Options specified in config should enable metrics collection.

[Metrics]
Enabled = true
EnabledExpensive = true

Actual behaviour

These options are ignored. Metrics server starts on 6060 port, but metrics are all zeroes, unless --metrics CLI arg is specified.

Steps to reproduce the behaviour

Add this lines to config.toml

[Metrics]
Enabled = true
EnabledExpensive = true
HTTP = "0.0.0.0"
Port = 6060

Start geth with flags --pprof --pprof.port=6060 --pprof.addr=0.0.0.0

Go to /debug/metrics/prometheus endpoint and all metrics will be zeroes.

Backtrace

[backtrace]
@holiman
Copy link
Contributor

holiman commented Oct 10, 2023

Yes, this is a known issue. See for example #24178

@wangyifan
Copy link
Contributor

I'll investigate the issue.

@holiman
Copy link
Contributor

holiman commented Dec 11, 2024

Fixed by #30814

@holiman holiman closed this as completed Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@holiman @wangyifan @VladStarr and others