Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uint256: switch over the legacy txpool from big.Int to uint256.Int #28577

Closed
karalabe opened this issue Nov 21, 2023 · 1 comment
Closed

uint256: switch over the legacy txpool from big.Int to uint256.Int #28577

karalabe opened this issue Nov 21, 2023 · 1 comment

Comments

@karalabe
Copy link
Member

We've built the uint256 library a long time ago, but never really got around to using it outside of the EVM. This is a shame, as the library is more performant than big.Int as well as more "correct", as in we don't need to special case overflows and negative numbers.

Whilst it might be non-trivial to switch certain parts of Geth over while keeping backwards compatibility, one place that might be easier is the txpool/legacytxpool internals. That should not ripple across our code at all, but should help make progress on the switchover effort.

@holiman
Copy link
Contributor

holiman commented Feb 13, 2024

Done in $28606

@holiman holiman closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants