Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/evm/internal/t8ntool: log writeTraceResult error message #30038

Merged
merged 2 commits into from
Jun 28, 2024
Merged

cmd/evm/internal/t8ntool: log writeTraceResult error message #30038

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d117bff
log writeTraceResult error message
mask-pp Jun 21, 2024
6c1007f
revert change
mask-pp Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cmd/evm/internal/t8ntool/execution.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,9 @@ func (pre *Prestate) Apply(vmConfig vm.Config, chainConfig *params.ChainConfig,
if tracer.Hooks.OnTxEnd != nil {
tracer.Hooks.OnTxEnd(receipt, nil)
}
writeTraceResult(tracer, traceOutput)
if err = writeTraceResult(tracer, traceOutput); err != nil {
log.Warn("Error writing tracer output", "err", err)
}
}
}

Expand Down Expand Up @@ -423,7 +425,6 @@ func calcDifficulty(config *params.ChainConfig, number, currentTime, parentTime
}

func writeTraceResult(tracer *tracers.Tracer, f io.WriteCloser) error {
defer f.Close()
result, err := tracer.GetResult()
if err != nil || result == nil {
return err
Expand All @@ -432,5 +433,5 @@ func writeTraceResult(tracer *tracers.Tracer, f io.WriteCloser) error {
if err != nil {
return err
}
return nil
return f.Close()
}