Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docs CI #2175

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Fix Docs CI #2175

merged 3 commits into from
Apr 19, 2024

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Apr 18, 2024

What was wrong?

docs CI was only installing dependencies and exiting.

How was it fixed?

Added the missing steps to the CI run.

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes changed the title Try to get docs build going Fix Docs CI Apr 18, 2024
@kclowes kclowes marked this pull request as ready for review April 18, 2024 22:06
Copy link
Collaborator

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

- run:
name: install latexpdf dependencies
command: |
sudo apt-get update
sudo apt-get install latexmk tex-gyre texlive-fonts-extra
- run:
name: run tox
command: python -m tox -r
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is python -m tox run -r in the other commands - I think it was a preference for newer versions of tox.

@kclowes kclowes merged commit d8df507 into ethereum:main Apr 19, 2024
54 checks passed
@kclowes kclowes deleted the fix-doc-ci branch April 19, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants