Note deprecation of constant keyword on functions #3426
Conversation
docs/contracts.rst
Outdated
| @@ -467,7 +467,7 @@ The following statements are considered modifying the state: | |||
| } | |||
|
|
|||
| .. note:: | |||
| ``constant`` is an alias to ``view``. | |||
| ``constant`` is an alias to ``view``, but this is `deprecated <https://github.com/ethereum/solidity/issues/992#issuecomment-322351715>`_ and will be removed in the next breaking release. | |||
There was a problem hiding this comment.
You do not have to cite github issues in the documentation. :)
Please also mention version 0.5.0 explicitly, not only relatively.
|
Thanks for clarifying the version number, I wasn't 100% sure and didn't want to edit in the wrong one. Though I appreciate that it's not required, I think the link to the GitHub issue where this was decided is appropriate, as somebody will be following old code/tutorials with |
docs/contracts.rst
Outdated
| @@ -467,7 +467,7 @@ The following statements are considered modifying the state: | |||
| } | |||
|
|
|||
| .. note:: | |||
| ``constant`` is an alias to ``view``. | |||
| ``constant`` was an alias to ``view``, but this is `deprecated <https://github.com/ethereum/solidity/issues/992#issuecomment-322351715>`_ and has been removed as of version 0.5.0. | |||
There was a problem hiding this comment.
There wasn't a 0.5.0 release yet, so this cannot be past tense. Also please do not include the github comment as it is irrelevant. This is the official documentation, no need to prove the content with links to issues.
|
Squashed, rebased and reworded. |
Per #992 (comment)