Accounts #869
Merged
Accounts #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozeman
commented
May 11, 2017
packages/web3-eth/src/accounts.js
Outdated
| this.length = 0; | ||
| } | ||
|
|
||
| Wallet.prototype.create = function (numberOfAccounts, entropy) { |
There was a problem hiding this comment.
Im unsure, if we shouldn't rename it to generate or so, as you can add new accounts with this function.
frozeman
commented
May 11, 2017
packages/web3-eth/src/accounts.js
Outdated
| } | ||
|
|
||
| Wallet.prototype.encrypt = function (password) { | ||
| var accounts = []; |
There was a problem hiding this comment.
The format and encryption should be the same as the geth keystore. See ~/Library/Ethereum/keystore
The go code is here i think: https://github.com/ethereum/go-ethereum/blob/master/accounts/keystore/keystore.go
frozeman
commented
May 11, 2017
packages/web3-eth/src/accounts.js
Outdated
| Wallet.prototype.defaultKeyName = "web3js_wallet"; | ||
|
|
||
| Wallet.prototype.save = function (password, keyName) { | ||
| localStorage.setItem(keyName || this.defaultKeyName, this.encrypt()); |
There was a problem hiding this comment.
On node.js we have to throw an error in this functions i think.
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
* Initial implementation of web3.eth.accounts * Use EthFP internally * Getting accounts closer to the desired api * Style changes * Partially implement web3.eth.accounts.wallet as specified * moved accounts to its own package * docs changes * Change gasLimit to gas * changed Accounts to class * added wallet access to sendTransaction * changing docs, in progress * improved docs and changed accounts package * fixed tests * fixed jshints * added wallet tests * added signTransaction tests for async signing * added signTransaction tests with iban addresses * changed EthFP -> EthLib * added account decrypt function * added wallet decrypt and encryption function * added decrypt and encryption tests * added account generation tests * made load save wallet work * added more static tests * added eth_sign tests * fixed lint errors * fixed travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds account creation and signing tools