Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Add timestamp field to setGenesisParams() #52

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Conversation

vpulim
Copy link
Contributor

@vpulim vpulim commented Aug 12, 2018

Currently, genesis block hashes are computed incorrectly for the Rinkeby network since the timestamp field is not included. This PR fixes that.

@coveralls
Copy link

coveralls commented Aug 12, 2018

Coverage Status

Coverage increased (+0.1%) to 73.333% when pulling 807fbf2 on genesis-timestamp into 99e9f9c on master.

@vpulim vpulim force-pushed the genesis-timestamp branch 2 times, most recently from 437c802 to 62cbc67 Compare August 25, 2018 14:18
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (how urgent is a release on this?).

@holgerd77 holgerd77 merged commit 2bda290 into master Sep 21, 2018
@holgerd77 holgerd77 deleted the genesis-timestamp branch September 21, 2018 09:36
@holgerd77
Copy link
Member

This has now been released within the v2.1.0 release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants