Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modexp should use Montgomery multiplication from bn.js #214

Closed
axic opened this issue Oct 5, 2017 · 0 comments · Fixed by #463
Closed

Modexp should use Montgomery multiplication from bn.js #214

axic opened this issue Oct 5, 2017 · 0 comments · Fixed by #463
Labels
help wanted package: vm prio: P4 nice-to-have type: refactor

Comments

@axic
Copy link
Member

axic commented Oct 5, 2017

Currently it uses a less optimised implementation: https://github.com/ethereumjs/ethereumjs-vm/blob/master/lib/precompiled/05-modexp.js#L57-L64

See bn.js: https://github.com/indutny/bn.js#reduction-context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted package: vm prio: P4 nice-to-have type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use BN reduction context in modexp precompile ethereumjs/ethereumjs-monorepo
3 participants
@axic @evertonfraga @holgerd77