Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API doc types and implementation for Bloom filter methods are inconsistent #332

Closed
holgerd77 opened this issue Aug 8, 2018 · 0 comments · Fixed by #439
Closed

API doc types and implementation for Bloom filter methods are inconsistent #332

holgerd77 opened this issue Aug 8, 2018 · 0 comments · Fixed by #439

Comments

@holgerd77
Copy link
Member

The bloom filter tests recently added with https://github.com/ethereumjs/ethereumjs-vm/pull/330/files discovered that types of API docs (expecting Buffer) and implementation (taking String) for most methods (e.g. here) are not consistent.

There should be another look on this and be determined if taking Buffer values should be enforced or if the API docs should be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants