Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary dynamic field in OpcodeInfo #573

Closed
s1na opened this issue Aug 5, 2019 · 1 comment · Fixed by #582
Closed

Unnecessary dynamic field in OpcodeInfo #573

s1na opened this issue Aug 5, 2019 · 1 comment · Fixed by #582
Labels
effort: E1 hours package: vm prio: P4 nice-to-have type: refactor

Comments

@s1na
Copy link
Contributor

s1na commented Aug 5, 2019

The dynamic field in OpcodeInfo doesn't seem to be used in the code. It's probably there for historical reasons. Haven't yet found what purpose it served but I guess we can remove it.
@holgerd77
Copy link
Member

@s1na If I am not completely wrong I think you removed the usage on this yourself during your refactoring work? 😄 😋 Yes, I think this can be removed now.

@s1na s1na mentioned this issue Aug 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: E1 hours package: vm prio: P4 nice-to-have type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Maintain separate list of opcodes for Istanbul ethereumjs/ethereumjs-monorepo
3 participants
@evertonfraga @holgerd77 @s1na