Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client: add block validation to chain syncing #981

Closed
holgerd77 opened this issue May 29, 2018 · 3 comments
Closed

Client: add block validation to chain syncing #981

holgerd77 opened this issue May 29, 2018 · 3 comments

Comments

@holgerd77
Copy link
Member

Description

Currently validation on chain syncing is not taking place, the blockchain class is initialized with validation set to false.

This should be changed. 😄

Possible Implementation

Work is largely taking place on the ethereumjs-block library, which has to be backported to support the pre-Byzantium validation rules, see PR below.

Depends on ethereumjs/ethereumjs-block#46 and ethereumjs/ethereumjs-blockchain#54.

@aunyks
Copy link
Contributor

aunyks commented Nov 13, 2018

Is this resolved or close to resolution?

@vpulim
Copy link
Contributor

vpulim commented Nov 15, 2018

Enabling the validate flag should pretty much work now for PoW chains. PoA chains like Rinkeby will still fail validation until these issues are solved:

https://github.com/ethereumjs/ethereumjs-block/issues/45
https://github.com/ethereumjs/ethereumjs-blockchain/issues/76

@holgerd77 holgerd77 transferred this issue from ethereumjs/ethereumjs-client Dec 4, 2020
@holgerd77 holgerd77 changed the title Add block validation to chain syncing Client: add block validation to chain syncing Dec 4, 2020
@holgerd77
Copy link
Member Author

Fixed in #1075, will close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants