[WIP] Run with the latest tests

[holgerd77]

Updated ethereumjs-testing to v1.2.0 (submodule 428842e)

[holgerd77]

Very modest result, one new failing test:
ecmul_0-3_5616_28000_96

Run with:

node tests/tester.js -s --test='ecmul_0-3_5616_28000_96'

Filler | Test

Output:

$ node tests/tester.js -s --test='ecmul_0-3_5616_28000_96'
TAP version 13
# GeneralStateTests
# file: ecmul_0-3_5616_28000_96 test: ecmul_0-3_5616_28000_96
not ok 1 the state roots should match
  ---
    operator: equal
    expected: |-
      '631a600601a67ef3357813281d417e141e5eddf306abd4d8824bdc141536e3c6'
    actual: |-
      '261abab5092a666776b6e956e2d572769b5cfef2fcff383ae956fcc75e36e133'
    at: replenish (/Users/hdrewes/Documents/DEV/EthereumJS/ethereumjs-vm/node_modules/async/dist/async.js:1011:17)
  ...
ok 2 the state roots should match
ok 3 the state roots should match
ok 4 the state roots should match

1..4
# tests 4
# pass  3
# fail  1

This is the one with the highest gas limit (taking 20000 from "gasLimit": [ "0xcaf8", "90000", "110000", "200000"]) - so d:0, g:3, v:0 - and so probably the test that is running through respectively would have enough gas to not run out of gas.

This is probably failing relatively early, since --jsontrace gives no output while testing on other d,g,v combination does.

This is going into this conditional statement with the following message (hidden):

sender doesn't have enough funds to send tx. The upfront cost is: 200000 and the sender's account only has: 150000

Run the single test case:

node tests/tester.js -s --test='ecmul_0-3_5616_28000_96' --data=0 --gas=3 --value=0 --jsontrace

This is probably failing due to some generic VM behavior and not due to problems with the corresponding precompile.

[holgerd77]

Just rebased this.

[holgerd77]

Rebased this, as a negative test for #313.

[axic]

Fails on:

# file: ecmul_0-3_5616_28000_96 test: ecmul_0-3_5616_28000_96
not ok 4554 the state roots should match
  ---
    operator: equal
    expected: |-
      '631a600601a67ef3357813281d417e141e5eddf306abd4d8824bdc141536e3c6'
    actual: |-
      '261abab5092a666776b6e956e2d572769b5cfef2fcff383ae956fcc75e36e133'
    at: replenish (/home/circleci/project/ethreumjs-vm/node_modules/async/dist/async.js:998:17)
  ...

[axic]

This may be fixed with my update to rustbn.js to use ethereum-bn128.rs?

[holgerd77]

@axic No, not fixed. Same test ecmul_0-3_5616_28000_96 failing.

[holgerd77]

Rebased this, mainly for the reason to have this also run with the Constantinople tests for a first impression (see #317).

[holgerd77]

Will remove the rustbn.js commit, this is breaking the build.

[axic]

Will remove the rustbn.js commit, this is breaking the build.

The reason it was breaking is because it pointed to a branch (PR), but that was merged and deleted. Lets try again with master.

[axic]

While the precompile cleanup doesn't fix the problem, I think they should be merged. Created #318.

[axic]

Debugging the ecmul issue locally.

[axic]

In the test case the input data is

0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000330644e72e131a029b85045b68181585d2833e84879b9709143e1f593f00000000000000000000000000000000000000000000000000000000000000000000000

And rustbn.js returns empty output, which means it considers it a failure.

To me that seems it has a curve point (0, 0) data (infinity...) multiplied with that large constant and has stray trailing data.

Update: this is the actual data properly decoded:

x: 0000000000000000000000000000000000000000000000000000000000000000
y: 0000000000000000000000000000000000000000000000000000000000000003
scalar: 30644e72e131a029b85045b68181585d2833e84879b9709143e1f593f0000000
stray: 0000000000000000000000000000000000000000000000000000000000000000

To this paritytech/bn says it is an invalid curve point. Is any other client passing this test?

Unfortunately only having hashes for state tests doesn't give any idea what it is expecting.

Here is the test source: https://github.com/ethereum/tests/blob/0eef2f31ab59016a7ccad2a99d4644f753eebcb9/src/GeneralStateTestsFiller/stZeroKnowledge2/ecmul_0-3_5616_28000_96Filler.json

Since it has an EVM blob I am not sure what it is intended to do. @winsvega any ideas? Are there any sources to those EVM blobs?

[axic]

@holgerd77 we would need to update our test repo after ethereum/tests#477. I would like to verify if the bitwise stuff still works.