-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client: sync from era1 #3869
Open
ScottyPoi
wants to merge
7
commits into
master
Choose a base branch
from
load-blocks-era
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Client: sync from era1 #3869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
17f36ce
to
304e0fa
Compare
Could this PR also add an issue template in |
146649d
to
b5e46f5
Compare
1399695
to
c5dcb16
Compare
c5dcb16
to
c5b5262
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the most basic version of what it could look like to sync a cient using
era1
files.We add an optional CLI flag
--loadBlocksFromEra1=<path_to_era1_dir>
Set this flag, and point it to a directory with
era1
files. We assume that the era1 files are named in such a way that alphabetical order equals chronological order.New fuction
eraSync()
will be called during client startup. This function will iterate through the directory of era1 files, store the extracted block data, then run block execution. The end result is a client synced to the height of the final era1 file.While this process does take time, it is faster than full sync via devp2p. More importantly, this method of syncing can be used in a post 4444 world, where this historical data may not be available over devp2p.
--
This concept is far from optimized. A more sophisticated version of era1Sync would avoid storing and recalling these blocks from the client database at all.
--
To test:
Download 1 or more era1 files from era1.ethportal.net
Start a client via CLI with the
--loadBlocksFromEra1
flag set, pointing towards the era1 directory.Observe the logs while each file is processed, and the client execution runs in batches of 8192 blocks.