Tx: transaction runner cleanup #3875
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
jochem-brouwer
force-pushed
the
tx-tests-cleanup
branch
3 times, most recently
from
1f87c08 to
b751b9c
Compare
jochem-brouwer
force-pushed
the
tx-tests-cleanup
branch
from
2ab7657 to
fbb5301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried cleaning up the tx transaction test runner to get rid of this
getTestsmethod.vitesthas aimport.meta.globwhich seems can help us.What I'd like to have though is a nice report of the tests. It currently starts empty reporting that it will run X tests and only reports once all tests are done. I'd like it to be dynamically updated (how to do this..?). Does not seem like I'm using any fancy test setup though so not sure how to make this look nice.