Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Prague as default HF #3877

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Set Prague as default HF #3877

wants to merge 5 commits into from

Conversation

jochem-brouwer
Copy link
Member

This PR:

  • Adds known fork timestamps for Holesky and Sepolia for Prague
  • Adds dummy Prague fork (with dummy timestamp) for mainnet
  • Sets default HFs to Prague for these chains

WIP, not sure when to merge, do we want to set Prague as default HF even if mainnet is not yet forked? 🤔

Closes #3876

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.62%. Comparing base (8630cc8) to head (29c5964).

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 77.03% <ø> (+0.16%) ⬆️
blockchain 85.69% <ø> (ø)
client ?
common 90.80% <100.00%> (+0.06%) ⬆️
devp2p 76.27% <ø> (ø)
ethash 81.04% <ø> (ø)
evm 71.17% <ø> (+0.12%) ⬆️
genesis 99.84% <ø> (ø)
mpt 59.52% <ø> (-0.21%) ⬇️
rlp 69.70% <ø> (ø)
statemanager 70.47% <ø> (ø)
tx 81.28% <ø> (+0.32%) ⬆️
util 85.54% <ø> (ø)
vm 58.62% <ø> (+0.81%) ⬆️
wallet 83.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jochem-brouwer
Copy link
Member Author

jochem-brouwer commented Feb 24, 2025

Oh wait, I just realized the client will obviously switch to the correct hardfork even if mainnet is currently not forked to Prague yet.

I think mainnet timestamps will be choosen soon.

Note: Holesky will fork today :)

I suggest to merge this once mainnet timestamps are choosen and committed to this PR.

@holgerd77
Copy link
Member

I suggest to merge this once mainnet timestamps are choosen and committed to this PR.

Yes, would agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Pectra the Default Hardfork
2 participants