Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EthJS monorepo-wide errors: EVM package #3880

Draft
wants to merge 4 commits into
base: ethjs-errors
Choose a base branch
from

Conversation

jochem-brouwer
Copy link
Member

@jochem-brouwer jochem-brouwer commented Feb 24, 2025

Follow up of #3714 (all commits there got squashed in a single commit here to avoid merge conflicts). This is a PR on top of #3879 to demonstrate integrating new error types.

commit 85aa5fa
Author: Jochem Brouwer <[email protected]>
Date:   Mon Feb 24 05:57:39 2025 +0100

    lint: add rule to disallow `new Error` throwing

commit 1e97567
Merge: a8cd9e1 bd77a74
Author: Jochem Brouwer <[email protected]>
Date:   Mon Feb 24 05:44:30 2025 +0100

    Merge branch 'master' into evm-error-handling

commit a8cd9e1
Author: Jochem Brouwer <[email protected]>
Date:   Mon Feb 24 05:44:21 2025 +0100

    util: introduce new temp error with unset error code

commit aa3702b
Author: Jochem Brouwer <[email protected]>
Date:   Mon Feb 10 16:04:41 2025 +0100

    vm/client: fix build

commit 16d1b38
Author: Jochem Brouwer <[email protected]>
Date:   Mon Feb 10 15:40:57 2025 +0100

    evm/util: update to new, simpler error format

commit ec01f1b
Author: Jochem Brouwer <[email protected]>
Date:   Mon Feb 10 14:37:24 2025 +0100

    util: update base error class

commit 70b2df5
Merge: 293f4cc 1774df6
Author: Jochem Brouwer <[email protected]>
Date:   Mon Feb 10 14:22:35 2025 +0100

    Merge branch 'master' into evm-error-handling

commit 293f4cc
Merge: b4458d7 99cfdd6
Author: Jochem Brouwer <[email protected]>
Date:   Tue Jan 14 03:04:15 2025 +0100

    Merge branch 'master' into evm-error-handling

commit b4458d7
Merge: 71e77dc 100d77d
Author: Jochem Brouwer <[email protected]>
Date:   Fri Dec 13 17:50:26 2024 +0100

    Merge branch 'master' into evm-error-handling

commit 71e77dc
Author: Jochem Brouwer <[email protected]>
Date:   Tue Oct 1 13:57:38 2024 +0200

    evm: fix err handling

commit d00b7bf
Author: Jochem Brouwer <[email protected]>
Date:   Tue Oct 1 13:46:08 2024 +0200

    evm/util: error overhaul
client: add TODO
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.80%. Comparing base (8585be6) to head (013c7ec).

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 76.78% <ø> (ø)
blockchain 85.43% <ø> (ø)
client 66.23% <100.00%> (ø)
common 90.75% <ø> (ø)
devp2p 76.27% <ø> (-0.07%) ⬇️
ethash 81.04% <ø> (ø)
evm ?
genesis 99.84% <ø> (ø)
mpt 59.68% <ø> (ø)
rlp 69.70% <ø> (ø)
statemanager 70.46% <ø> (ø)
tx 81.20% <ø> (ø)
util 84.86% <100.00%> (+<0.01%) ⬆️
vm 57.77% <100.00%> (ø)
wallet 83.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jochem-brouwer jochem-brouwer added the type: test all hardforks This special label enables VM state and blockchain tests for all hardforks on the respective PR. label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: evm PR state: WIP type: test all hardforks This special label enables VM state and blockchain tests for all hardforks on the respective PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant