Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Simplify Transaction constructor's options #149

Closed
alcuadrado opened this issue Apr 29, 2019 · 3 comments · Fixed by #153
Closed

Simplify Transaction constructor's options #149

alcuadrado opened this issue Apr 29, 2019 · 3 comments · Fixed by #153

Comments

@alcuadrado
Copy link
Member

There are multiple ways to set the chain that a transaction belongs to, this can/should be simplified.

I'm opening this issue as a continuation of the discussions that happened here, here, and here.

@holgerd77
Copy link
Member

Another question I have related to this: how justified is this constructor option split into "data" and "opts" dictionaries?

@alcuadrado
Copy link
Member Author

I think they were separated because of how defineProperties work. But I don't have enough knowledge about the history of this library.

@holgerd77
Copy link
Member

@alcuadrado ah ok, I think I already stumbled upon that one but forgot again, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants