Fix failing blockchain test GasLimitHigherThan2p63m1 #380
+26
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the test GasLimitHigherThan2p63m1. `runBlock` should fail when the supplied block has a gas limit higher than `2^63 - 1 but currently this validation doesn't occur.
|
Can you also remove the test from being excluded in the state tests? |
|
Sorry @axic I must be missing something. Where is this test being skipped? |
|
@axic This is a blockchain test only test not included in the state test suite. @mattdean-digicatapult Generally there are some (but few) tests commented out as being broken in tester.js, we should retry those once all these changes here have been merged, lots of changes in tests passing lately, thank you also for doing these side improvements along the road 👍) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the test GasLimitHigherThan2p63m1.
runBlockshould fail when the supplied block has a gas limit higher than2^63 - 1but currently this validation doesn't occur.I ran into one of the failing blockchain tests from #338 whilst doing work on #376. The above test now passes but what I find odd is I can't find a reference to this in an EIP or in the yellow paper. I can see this exact logic present in
cpp-ethereumandgo-ethereumthough so I thought I'd throw this out there. It might be the constant is better inethereumjs-commonbut I left it in here for now; quite happy to update this if desired.