Clear stateManager cache after setStateRoot #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgerd77
force-pushed
the
state-manager-clear-cache-after-set-state-root
branch
from
7509cb2 to
784cfeb
Compare
holgerd77
approved these changes
Jan 16, 2019
There was a problem hiding this comment.
Looks good, thanks @davidmurdoch for working this out and @mattdean-digicatapult for the quick reaction on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #417
Clears the
stateManagercache after setting the state root such that stale values are not returned.There's an additional problem whereby the empty trie root is apparently not included in the
merkle-patricia-treeeven when this is constructed empty. An additional check has been added to prevent this causing an error insetStateRoot, though I wonder if this should instead be changed in themerkle-patricia-tree.