Convert Bloom to es6 class

[s1na]

Converts Bloom to an es6 class, and moves it to a directory to have it as a separate module.

My thinking is to structure the VM as multiple modules which contain most of the code, and in the root directory (lib/) have code that connects these individual modules together. This should also ease our way into a monorepo (if we decided to go for it). Bloom was a low-hanging fruit, I'll create an issue to discuss how to structure the rest of the code.

Bloom is used only internally, and is not exposed, so this shouldn't be a breaking change.

[holgerd77]

The bloom file here is also showing as deleted + new file, can you change that for review? If you did renaming via git maybe you have to do it in two steps like:

1. bloom.js-> bloom/bloom.js
2. bloom/bloom.js -> bloom/index.js

? Just an idea, have absolutely no confirmation if this would work better.

[holgerd77]

(and if so probably accompanied by two separate renaming commits for GitHub to process)

[coveralls]

Coverage decreased (-0.03%) to 90.987% when pulling c71fcae on refactor/bloom-es6 into f154d2c on master.

[s1na]

Yeah this is a big issue, I have to find a fix. Maybe I'm doing something wrong in my work flow. I re-worked the commit history and even though the first commit clearly shows this is only a rename, but it's still being shown as a removed file and an added file... Should I do it in two PRs?

[holgerd77]

Can/did you try to do it in two steps like I suggested above and do one commit per step (so first commit just for directory move, second commit for file renaming)? Maybe this becomes easier for GitHub to process?

[holgerd77]

Found this similar problem description gogs/gogs#5056.

Also points in the direction that the suggestion above could eventually fix this.

[s1na]

It is detecting the rename in the first commit, I think it's the large (relative to the file itself) diff that causes it to treat it as a deleted+new file across commits. Created #429 to break it into two PRs.

[holgerd77]

Ok, have reviewed and merged.

[holgerd77]

Looks good.