-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced static vm logTable with dynamic inline version in EXP opcode #450
Replaced static vm logTable with dynamic inline version in EXP opcode #450
Conversation
Ah, this would be another 1%+ coverage increase. I know on the one hand this is cosmetics, on the other hands obscure code parts like these distract from the more important coverage improvement necessities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I was confused what the role of logTable
is sometime ago. This PR makes it clear it's not absolutely necessary and can be very much simplified without much performance penalty!
I just had a few small comments and questions, basically to understand better what EXP
is doing and whether it can be simplified further.
In this first round I was only looking for some functional replacement without fully understand the functionality. Will go through your comments and have a look what can be integrated, definitely worth to do a second round here. |
39b2546
to
ce56b8a
Compare
0ab8b26
to
a20b07f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great now!
Addresses #449, 1. List Item