-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use EEI methods in opFns #486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 Cool! Will look into this shortly. |
holgerd77
approved these changes
Apr 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am through, again, not line-by-line but checking overall consistency. I find this PR fantastic, since it brings so much clarity to the core logic here, would actually give this a go. Great work Sina! 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed (#455, #441), this PR introduces an interface exposed to the EVM for interacting with its environment. It closely resembles (and was inspired by) the ewasm EEI spec, the main difference being how input and output data is handled (ewasm requires buffers to be exchanged via memory).
The biggest changes are in how CALLs and CREATEs are handled. Although the logic is the same, there are now multiple functions for handling each specific type (as opposed to
makeCall
which handled everything).The list ofselfdestruct
ed contracts is also kept now inInterpreter
as part of atxRunState
instead of being passed around with every message (added torunCode
for backwards compatibility).(To be merged into #479)