From ea6e9674c6c313b9e5dd9cccc952d43a11be1d9b Mon Sep 17 00:00:00 2001 From: Chris Sewell Date: Sat, 4 Dec 2021 14:35:26 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20FIX:=20Convert=20empty=20directi?= =?UTF-8?q?ve=20option=20to=20`None`=20(#452)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This allows for converters like `optional_int` to work correctly --- myst_parser/parse_directives.py | 2 +- tests/test_renderers/fixtures/sphinx_directives.md | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/myst_parser/parse_directives.py b/myst_parser/parse_directives.py index c3c4375d..352f67bf 100644 --- a/myst_parser/parse_directives.py +++ b/myst_parser/parse_directives.py @@ -147,7 +147,7 @@ def parse_directive_options( raise DirectiveParsingError(f"Unknown option: {name}") if not isinstance(value, str): if value is True or value is None: - value = "" # flag converter requires no argument + value = None # flag converter requires no argument elif isinstance(value, (int, float, datetime.date, datetime.datetime)): # convertor always requires string input value = str(value) diff --git a/tests/test_renderers/fixtures/sphinx_directives.md b/tests/test_renderers/fixtures/sphinx_directives.md index 3b737c86..a84040ef 100644 --- a/tests/test_renderers/fixtures/sphinx_directives.md +++ b/tests/test_renderers/fixtures/sphinx_directives.md @@ -45,8 +45,9 @@ highlight (`sphinx.directives.code.Highlight`): code-block (`sphinx.directives.code.CodeBlock`): . ```{code-block} +:dedent: -a=1 + a=1 ``` .