-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] Upgrade @expo/multipart-body-parser #2751
[eas-cli] Upgrade @expo/multipart-body-parser #2751
Conversation
Subscribed to pull request
Generated by CodeMention |
665f05a
to
d178d04
Compare
Size Change: -915 B (0%) Total Size: 53.4 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2751 +/- ##
=======================================
Coverage 52.51% 52.51%
=======================================
Files 583 583
Lines 22576 22576
Branches 4447 4447
=======================================
Hits 11854 11854
Misses 10687 10687
Partials 35 35 ☔ View full report in Codecov by Sentry. |
@@ -11,6 +11,7 @@ This is the log of notable changes to EAS CLI and related packages. | |||
### 🐛 Bug fixes | |||
|
|||
- Bump `@expo/apple-utils` to fix sending two-factor authentication codes via SMS. ([#2750](https://github.com/expo/eas-cli/pull/2750) by [@EvanBacon](https://github.com/EvanBacon)) | |||
- Upgrade @expo/multipart-body-parser. ([#2751](https://github.com/expo/eas-cli/pull/2751) by [@wschurman](https://github.com/wschurman)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will probably need to rebase this PR before merging so the changelog entry is placed under the correct release (a new release was published)
d178d04
to
3a9d7bf
Compare
✅ Thank you for adding the changelog entry! |
Why
There's a CVE in dicer and there's no fix planned: GHSA-wm7h-9275-46v2
mscdex/dicer#22
@expo/multipart-body-parser
used dicer until 2.0.0.Closes ENG-14330.
Fixes expo/expo#20225.
How
Version 2.0.0 of
@expo/multipart-body-parser
moved it off of dicer.Test Plan
Publish a code signed update (the part of eas-cli that uses this library):