-
Notifications
You must be signed in to change notification settings - Fork 404
feat: allow setting type in external secret to support other than Opaque secrets #130
feat: allow setting type in external secret to support other than Opaque secrets #130
Conversation
000ae93
to
afc2a71
Compare
@silasbw @jeffpearce Please have a look :D |
examples/tls-example.yml
Outdated
backendType: secretsManager | ||
type: kubernetes.io/tls | ||
data: | ||
- key: /development/certifcate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda a nit, but
- key: /development/certifcate | |
- key: /development/certificate |
examples/tls-example.yml
Outdated
- key: /development/certifcate | ||
property: crt | ||
name: tls.crt | ||
- key: /development/certifcate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- key: /development/certifcate | |
- key: /development/certificate |
Would you mind adding a test? |
@jeffpearce test added and typo fixed 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Flydiverny !
I'm not familiar with the release process here, but I'm closely tracking this PR because I have immediate use for it. When is the next release (1.3.2 ?) expected to make it out? |
My team is eagerly awaiting this change as well, can we get an ETA on the next release? |
…que secrets (external-secrets#130) * feat: allow setting type in external secret to support other than Opaque secrets
Possible solution for #109
Originally posted by @Flydiverny in #109 (comment)