This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
Retrieve binary secrets from AWS Secrets Manager #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@silasbw @Flydiverny Could you please take a look? |
silasbw
reviewed
Nov 6, 2019
| @@ -39,6 +39,9 @@ class SecretsManagerBackend extends KVBackend { | |||
| .getSecretValue({ SecretId: secretKey }) | |||
| .promise() | |||
|
|
|||
| if (data.SecretString === undefined) { | |||
There was a problem hiding this comment.
can you tweak this to explicitly check for the existence of the properties? I.e.,
if ('SecretBinary' in data) {
return data.SecretBinary
} else if ('SecretString' in data) {
return data.SecretString
}
this._logger('Unexpected data from Secrets Manager secret ${secretKey}')
return nullThere was a problem hiding this comment.
@silasbw thank you for the comment, I fixed it.
Flydiverny
approved these changes
Nov 7, 2019
Flydiverny
suggested changes
Nov 7, 2019
| return data.SecretString | ||
| } | ||
|
|
||
| this._logger(`Unexpected data from Secrets Manager secret ${secretKey}`) |
There was a problem hiding this comment.
Suggested change
| this._logger(`Unexpected data from Secrets Manager secret ${secretKey}`) | |
| this._logger.error(`Unexpected data from Secrets Manager secret ${secretKey}`) |
There was a problem hiding this comment.
Thank you! I changed logging level
Flydiverny
approved these changes
Nov 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #149 issue