This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
Feat: e2e tests #207
Merged
Feat: e2e tests #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doh just added some crd validation things as well, just hadn't gotten to creating the pr 😅 (#208) |
|
Thanks, i'll remove my crd changes then. |
Flydiverny
reviewed
Nov 8, 2019
silasbw
reviewed
Nov 9, 2019
silasbw
approved these changes
Nov 11, 2019
Co-Authored-By: Markus Maga <[email protected]>
|
Thanks for your comments! I changed the deployment name for more clarity and squashed my changes into a single commit. |
silasbw
reviewed
Nov 11, 2019
| @@ -39,6 +39,7 @@ const systemManagerBackend = new SystemManagerBackend({ | |||
| logger | |||
| }) | |||
| const backends = { | |||
| // when adding a new backend, make sure to change the CRD property too | |||
There was a problem hiding this comment.
is this comment still valid, or is it an artifact from a previous revision?
There was a problem hiding this comment.
its valid :) he had CRD validation in this PR first, but since I had a pr for it as well it was removed from here, but it still applies!
Flydiverny
approved these changes
Nov 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I'd like to add e2e tests to the repository in order to test the full path including helm chart configuration, AWS/Localstack integration and the good path (create ES, read data from SSM, wait for secret to appear). This is a first iteration, we can add more tests later on.
I also added validation to the
custom-resource-manifest.json(using the new.specfield).Unfortunately, we can't test the STS/assume-role integration - local stack does not seem to support it.