Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

Add empty keyOptions for dataFrom case. #221

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Add empty keyOptions for dataFrom case. #221

merged 1 commit into from
Nov 15, 2019

Conversation

iAnomaly
Copy link
Contributor

Resolves #220.

@iAnomaly
Copy link
Contributor Author

iAnomaly commented Nov 15, 2019

@Flydiverny.

I'm getting test failures locally related to Object.fromEntries @ kv-backend.js:116:

TypeError: Object.fromEntries is not a function
at KVBackend.getSecretManifestData (lib/backends/kv-backend.js:116:19)

Will wait and see if Travis fails too.

@Flydiverny
Copy link
Member

@Flydiverny.

I'm getting test failures locally related to Object.fromEntries @ kv-backend.js:116. Will wait and see if Travis fails too.

TypeError: Object.fromEntries is not a function
at KVBackend.getSecretManifestData (lib/backends/kv-backend.js:116:19)

fromEntries requires node 12 if you are not using that :)

@iAnomaly
Copy link
Contributor Author

@Flydiverny, you're right; that was it. Was still on node 10 locally. Upgraded to 12 and everything passing. 🎉

@Flydiverny Flydiverny merged commit 8e838ee into external-secrets:master Nov 15, 2019
@iAnomaly iAnomaly deleted the fix-secret-version-stage branch November 15, 2019 16:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.2.0 Failing with TypeError: Cannot destructure property versionStage of 'undefined' or 'null'.
2 participants