Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

Handle token failures #497

Merged
merged 2 commits into from
Oct 6, 2020

Conversation

megakid
Copy link
Contributor

@megakid megakid commented Sep 26, 2020

(note this also includes PR #488 - will tidy up after that one is merged)

This fixes #484

@megakid megakid force-pushed the handle-token-failures branch from c339355 to da970da Compare September 29, 2020 14:12
@Flydiverny
Copy link
Member

@megakid please update when you have some time and I'll try to review and merge!

@megakid megakid force-pushed the handle-token-failures branch from da970da to 3e1e290 Compare October 6, 2020 19:25
@megakid
Copy link
Contributor Author

megakid commented Oct 6, 2020

@megakid please update when you have some time and I'll try to review and merge!

All done - thanks @Flydiverny

Copy link
Member

@Flydiverny Flydiverny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sane to me :)

@Flydiverny Flydiverny merged commit c3c27bc into external-secrets:master Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling Vault token with Max TTL
2 participants